Add support for custom fonts in SVGs. #1742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the interface `SvgCustomFonts` and a corresponding parameter to the SvgImage widget. This provides a mechanism to support SVGs that have known fonts referenced in them. Closes DavBfr#1731.
DavBfr
reviewed
Sep 19, 2024
|
My thought was that it would be easier to extend for some unforeseen need
but that may be unnecessary. Happy to change to a function if you'd prefer.
…On Thu, Sep 19, 2024, 05:55 David PHAM-VAN ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pdf/lib/src/widgets/svg.dart
<#1742 (comment)>:
> @@ -154,3 +160,7 @@ class DecorationSvgImage extends DecorationGraphic {
);
}
}
+
+abstract class SvgCustomFonts {
Why not just a function?
—
Reply to this email directly, view it on GitHub
<#1742 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHEHH3P7NUHSVGYXFYYU6LZXKNSNAVCNFSM6AAAAABOHDPZVCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMJVGAZDSNRYG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Yes, just a function would be fine, thanks. |
|
Is the CI failure related to this PR? I'm not sure what I'm looking at there. |
|
I investigated the test failure, which was occuring because I haven't updated the
Would you like me to update the |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the interface
SvgCustomFontsand a corresponding parameter to theSvgImagewidget. This provides a mechanism to support SVGs that have known fonts referenced in them.Closes #1731.
Happy to make any changes!